Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: safer_mysql module's assign_public_ip input should be bool type #541

Merged
merged 2 commits into from Nov 16, 2023

Conversation

leavesster
Copy link
Contributor

@leavesster leavesster commented Nov 16, 2023

Fix

the safer_mysql submodule's assign_public_ip's type is string, but default value is false which is bool type

variable "assign_public_ip" {
  description = "Set to true if the master instance should also have a public IP (less secure)."
  type        = string
  default     = false
}

and this variable is used as bool parameter to ip_configuration.ipv4_enabled

ipv4_enabled = var.assign_public_ip

but the ipv4_enabled is require bool type not string.
It also effects example mysql-private at

current action

if I run terraform apply in example/mysql-private , it will reject to run because of this wrong type.

Copy link

google-cla bot commented Nov 16, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@imrannayer imrannayer changed the title fix: safer_mysql module's assign_public_ip input should be bool type fix!: safer_mysql module's assign_public_ip input should be bool type Nov 16, 2023
@imrannayer
Copy link
Collaborator

@leavesster thanks for the PR. lint test is failing. Plz generate docs. You can follow this doc

@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer imrannayer merged commit 4521594 into terraform-google-modules:master Nov 16, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants