Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make MySQL CloudSQL zone optional #572

Conversation

j8r
Copy link
Contributor

@j8r j8r commented Jan 30, 2024

Make MySQL CloudSQL zone variable optional, as PostgreSQL zone.

@j8r j8r requested review from isaurabhuttam, imrannayer and a team as code owners January 30, 2024 22:12
@imrannayer
Copy link
Collaborator

@j8r thanks for the PR. Can you plz fix lint issues?

@j8r j8r force-pushed the make-mysql-cloudsql-zone-optional branch from 0b0a9d2 to 143bc82 Compare February 6, 2024 00:20
@g-awmalik
Copy link
Contributor

/gcbrun

@g-awmalik
Copy link
Contributor

Fixes #526

@g-awmalik g-awmalik merged commit 3c4b504 into terraform-google-modules:master Feb 6, 2024
4 checks passed
@j8r j8r deleted the make-mysql-cloudsql-zone-optional branch February 6, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants