fix: Improve MySQL root_password documentation #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j8r
requested review from
isaurabhuttam,
imrannayer and
a team
as code owners
|
@j8r thx for the PR. Can you plz fix the lint issue? |
|
/gcbrun |
Make also root_password nullable by default as a clearer semantic.
j8r
force-pushed
the
fix-mysql-root-password-documentation
branch
from
ead78f6
to
4b719ed
Compare
|
/gcbrun |
g-awmalik
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
root_passwordis not generated inside the module if not set.Make also root_password nullable by default as a clearer semantic.