Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_function_app - Added storage_account_id and storage_account_access_key #6304

Merged
merged 7 commits into from Apr 22, 2020

Conversation

mbfrahry
Copy link
Member

@mbfrahry mbfrahry commented Mar 31, 2020

Deprecated storage_account_connection_string

Based off of #5645

(fixes #5435)

@mbfrahry mbfrahry requested a review from a team March 31, 2020 16:01
@mbfrahry mbfrahry changed the title azurerm_function_app - Added storage_account_id and storage_account_access_key [WIP] azurerm_function_app - Added storage_account_id and storage_account_access_key Mar 31, 2020
@mbfrahry mbfrahry changed the title [WIP] azurerm_function_app - Added storage_account_id and storage_account_access_key azurerm_function_app - Added storage_account_id and storage_account_access_key Mar 31, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@katbyte katbyte added this to the v2.7.0 milestone Apr 22, 2020
@mbfrahry mbfrahry merged commit b5f35ab into master Apr 22, 2020
@mbfrahry mbfrahry deleted the p-function-app-storage-connection-string branch April 22, 2020 15:42
mbfrahry added a commit that referenced this pull request Apr 22, 2020
@ghost
Copy link

ghost commented Apr 23, 2020

This has been released in version 2.7.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.7.0"
}
# ... other configuration ...

neil-yechenwei pushed a commit to neil-yechenwei/terraform-provider-azurerm that referenced this pull request Apr 26, 2020
neil-yechenwei pushed a commit to neil-yechenwei/terraform-provider-azurerm that referenced this pull request Apr 26, 2020
@ghost
Copy link

ghost commented May 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators May 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing the azurerm_function_app storage_connection_string causes a recreate when it shouldn't
2 participants