Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New resource - azurerm_servicebus_namespace_network_rule_set #6379

Merged
merged 3 commits into from Apr 21, 2020
Merged

New resource - azurerm_servicebus_namespace_network_rule_set #6379

merged 3 commits into from Apr 21, 2020

Conversation

ArcturusZhang
Copy link
Contributor

@ArcturusZhang ArcturusZhang commented Apr 7, 2020 •
edited

Introduces new resource azurerm_servicebus_namespace_network_rule_set

Fixes #3930

@ArcturusZhang ArcturusZhang mentioned this pull request Apr 14, 2020
Closed
aristosvo
aristosvo reviewed Apr 14, 2020
View reviewed changes
Copy link
Collaborator

@aristosvo aristosvo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general! Your PR is more extensive anyway, good job!

Fixes also #2255

azurerm/internal/services/servicebus/resource_arm_servicebus_namespace_network_rule.go Outdated Show resolved Hide resolved
@aristosvo aristosvo mentioned this pull request Apr 14, 2020
Closed
@ArcturusZhang ArcturusZhang force-pushed the servicebus-namespace-enhancement branch from f5e48d6 to be98e95 Compare April 15, 2020 03:18
@ArcturusZhang
Copy link
Contributor Author

Thanks @aristosvo for the review! I have changed the ip_masks to ip_rules, and also, since I just realized that this resource actually contains a lot of network rules, therefore the name azurerm_servicebus_namespace_network_rule may not be so suitable for this, therefore I changed the resource name to azurerm_servicebus_namespace_network_rule_set (same as the REST API implies) as well as a bunch of file names.
Please have a look, thanks!

@ArcturusZhang ArcturusZhang changed the title New resource - azurerm_servicebus_namespace_network_rule New resource - azurerm_servicebus_namespace_network_rule_set Apr 15, 2020
aristosvo
aristosvo reviewed Apr 15, 2020
View reviewed changes
Copy link
Collaborator

@aristosvo aristosvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes in the docs.

website/docs/r/servicebus_namespace_network_rule_set.html.markdown Outdated Show resolved Hide resolved
website/docs/r/servicebus_namespace_network_rule_set.html.markdown Outdated Show resolved Hide resolved
website/docs/r/servicebus_namespace_network_rule_set.html.markdown Outdated Show resolved Hide resolved
@ArcturusZhang
Copy link
Contributor Author

Hi @aristosvo thanks for the review! I have resolved those comments, please have a look

@katbyte katbyte mentioned this pull request Apr 21, 2020
Closed
@katbyte katbyte added this to the v2.7.0 milestone Apr 21, 2020
katbyte
katbyte approved these changes Apr 21, 2020
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArcturusZhang! LGTM 👍

katbyte added a commit that referenced this pull request Apr 21, 2020
@katbyte
update CHANGELOG.md to include #6379
dc3e6ab
@katbyte katbyte merged commit 50bb45e into hashicorp:master Apr 21, 2020
@ArcturusZhang ArcturusZhang deleted the servicebus-namespace-enhancement branch April 22, 2020 04:11
@ghost
Copy link

ghost commented Apr 23, 2020

This has been released in version 2.7.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.7.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

@aristosvo aristosvo aristosvo approved these changes

Assignees
No one assigned
Labels
documentation new-resource service/service-bus size/XXL
Projects
None yet
Milestone
v2.7.0
Development

Successfully merging this pull request may close these issues.

Add support for binding Azure Servicebus Namespace to a VNet
4 participants
@ArcturusZhang @katbyte @aristosvo @magodo