Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix azurerm_sql_database blob auditing error under online secondary create mode #6402

Merged
merged 6 commits into from Apr 26, 2020

Conversation

yupwei68
Copy link
Contributor

@yupwei68 yupwei68 commented Apr 8, 2020

Fix #6269
sql db secondary pass
Fix #6283

@ghost ghost added the size/M label Apr 8, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @yupwei68, should we also make the change for azurerm_mssql_database resource?

@yupwei68
Copy link
Contributor Author

hi @katbyte , you mean add blob auditing policies in mssql_database?

@ghost ghost removed the waiting-response label Apr 15, 2020
@ghost ghost added size/L documentation and removed size/M labels Apr 15, 2020
@ghost ghost added size/M and removed size/L labels Apr 15, 2020
@katbyte
Copy link
Collaborator

katbyte commented Apr 15, 2020

@yupwei68 - yep, given they are both basically the same resource just mssql is using the newer API

@ghost ghost added size/XL and removed size/M labels Apr 16, 2020
yupwei added 2 commits April 17, 2020 10:37
@yupwei68 yupwei68 requested a review from katbyte April 17, 2020 07:18
@yupwei68
Copy link
Contributor Author

hi @katbyte , auditing polices are added to azurerm_mssql_database. All tests have been passed.
=== RUN TestAccAzureRMMsSqlDatabase_basic
=== PAUSE TestAccAzureRMMsSqlDatabase_basic
=== CONT TestAccAzureRMMsSqlDatabase_basic
--- PASS: TestAccAzureRMMsSqlDatabase_basic (327.69s)
=== RUN TestAccAzureRMMsSqlDatabase_requiresImport
=== PAUSE TestAccAzureRMMsSqlDatabase_requiresImport
=== CONT TestAccAzureRMMsSqlDatabase_requiresImport
--- PASS: TestAccAzureRMMsSqlDatabase_requiresImport (486.89s)
=== RUN TestAccAzureRMMsSqlDatabase_complete
=== PAUSE TestAccAzureRMMsSqlDatabase_complete
=== CONT TestAccAzureRMMsSqlDatabase_complete
--- PASS: TestAccAzureRMMsSqlDatabase_complete (324.84s)
=== RUN TestAccAzureRMMsSqlDatabase_elasticPool
=== PAUSE TestAccAzureRMMsSqlDatabase_elasticPool
=== CONT TestAccAzureRMMsSqlDatabase_elasticPool
--- PASS: TestAccAzureRMMsSqlDatabase_elasticPool (270.30s)
=== RUN TestAccAzureRMMsSqlDatabase_GP
=== PAUSE TestAccAzureRMMsSqlDatabase_GP
=== CONT TestAccAzureRMMsSqlDatabase_GP
--- PASS: TestAccAzureRMMsSqlDatabase_GP (293.69s)
=== RUN TestAccAzureRMMsSqlDatabase_GP_Serverless
=== PAUSE TestAccAzureRMMsSqlDatabase_GP_Serverless
=== CONT TestAccAzureRMMsSqlDatabase_GP_Serverless
--- PASS: TestAccAzureRMMsSqlDatabase_GP_Serverless (306.51s)
=== RUN TestAccAzureRMMsSqlDatabase_BC
=== PAUSE TestAccAzureRMMsSqlDatabase_BC
=== CONT TestAccAzureRMMsSqlDatabase_BC
--- PASS: TestAccAzureRMMsSqlDatabase_BC (721.70s)
=== RUN TestAccAzureRMMsSqlDatabase_HS
=== PAUSE TestAccAzureRMMsSqlDatabase_HS
=== CONT TestAccAzureRMMsSqlDatabase_HS
--- PASS: TestAccAzureRMMsSqlDatabase_HS (836.07s)
=== RUN TestAccAzureRMMsSqlDatabase_createCopyMode
=== PAUSE TestAccAzureRMMsSqlDatabase_createCopyMode
=== CONT TestAccAzureRMMsSqlDatabase_createCopyMode
--- PASS: TestAccAzureRMMsSqlDatabase_createCopyMode (505.46s)
=== RUN TestAccAzureRMMsSqlDatabase_createPITRMode
=== PAUSE TestAccAzureRMMsSqlDatabase_createPITRMode
=== CONT TestAccAzureRMMsSqlDatabase_createPITRMode
--- PASS: TestAccAzureRMMsSqlDatabase_createPITRMode (1320.76s)
=== RUN TestAccAzureRMMsSqlDatabase_createSecondaryMode
=== PAUSE TestAccAzureRMMsSqlDatabase_createSecondaryMode
=== CONT TestAccAzureRMMsSqlDatabase_createSecondaryMode
--- PASS: TestAccAzureRMMsSqlDatabase_createSecondaryMode (423.64s)
=== RUN TestAccAzureRMMsSqlDatabase_threatDetectionPolicy
=== PAUSE TestAccAzureRMMsSqlDatabase_threatDetectionPolicy
=== CONT TestAccAzureRMMsSqlDatabase_threatDetectionPolicy
--- PASS: TestAccAzureRMMsSqlDatabase_threatDetectionPolicy (429.83s)
=== RUN TestAccAzureRMSqlDatabase_withBlobAuditingPolices
=== PAUSE TestAccAzureRMSqlDatabase_withBlobAuditingPolices
=== CONT TestAccAzureRMSqlDatabase_withBlobAuditingPolices
--- PASS: TestAccAzureRMSqlDatabase_withBlobAuditingPolices (599.26s)

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yupwei68! LGTM 👍

@katbyte katbyte merged commit ca6c4b2 into hashicorp:master Apr 26, 2020
katbyte added a commit that referenced this pull request Apr 26, 2020
@ghost
Copy link

ghost commented May 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators May 26, 2020
@yupwei68 yupwei68 deleted the wyp-sqldb-issue branch July 10, 2020 02:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants