Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add virtual resource association: azurerm_nat_gateway_public_ip #6450

Merged
merged 10 commits into from May 27, 2020

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Apr 13, 2020

fixes #6052

@ArcturusZhang ArcturusZhang added bug service/nat-gateway new-virtual-resource Resources which are split out to enhance the user experience labels Apr 20, 2020
@@ -42,6 +42,7 @@ func dataSourceArmNatGateway() *schema.Resource {
Elem: &schema.Schema{
Type: schema.TypeString,
},
Deprecated: "Deprecated in favor of `azurerm_nat_gateway_public_ip_association`",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this still makes sense for the data source?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems no need to remove. Thanks.Updated

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neil-yechenwei, LGTM 👍

@katbyte katbyte added this to the v2.12.0 milestone May 27, 2020
@katbyte katbyte merged commit d22a9d9 into hashicorp:master May 27, 2020
katbyte added a commit that referenced this pull request May 27, 2020
katbyte pushed a commit that referenced this pull request May 28, 2020
…delta updates in `azurerm_nat_gateway` (#7106)

This PR fixes some issues spotted in #6450 - namely:

Using a custom Resource ID for the azurerm_nat_gateway_public_ip_association resource - which includes the Public IP Address ID so that we can determine which Public IP Address is being referenced
Supporting delta updates in the azurerm_nat_gateway resource
@ghost
Copy link

ghost commented May 28, 2020

This has been released in version 2.12.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.12.0"
}
# ... other configuration ...

pbrit pushed a commit to pbrit/terraform-provider-azurerm that referenced this pull request May 31, 2020
pbrit pushed a commit to pbrit/terraform-provider-azurerm that referenced this pull request May 31, 2020
pbrit pushed a commit to pbrit/terraform-provider-azurerm that referenced this pull request May 31, 2020
…delta updates in `azurerm_nat_gateway` (hashicorp#7106)

This PR fixes some issues spotted in hashicorp#6450 - namely:

Using a custom Resource ID for the azurerm_nat_gateway_public_ip_association resource - which includes the Public IP Address ID so that we can determine which Public IP Address is being referenced
Supporting delta updates in the azurerm_nat_gateway resource
@ghost
Copy link

ghost commented Jun 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug documentation new-virtual-resource Resources which are split out to enhance the user experience service/nat-gateway size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NatGateway: Public IP is not detached if intended to be deleted
3 participants