provider: upgrade API Management to 2019-12-01

[katbyte]

No description provided.

[francescopersico]

This is not a simple rename.

An apim subscription can be tied to:

• a product -> "/products/{productId}"
• all apis -> "/apis"
• a single api -> "/apis/{apiId}"

So i think you must create a new block called "scope" with all the 3 options and in the docs you must document that only one must be filled like:

scope {
all_apis: boolean
api_name: string
product_name: string
}

used as:

scope {
product_name: "myproduct"
}

and than set the scope in SubscriptionCreateParameterProperties like
Scope: "/products/myproduct"

Hope it make sense.

[tombuildsstuff]

thinking about this, this probably wants two fields here: api_id and product_id - both of which are optional & conflict with each other; which'll allow all 3 conditions to be met

[katbyte]

@francescopersico - i believe as i have coded it the original behaviour will be preserved? i'll leave adding the additional properties/block to a future PR by someone who knows this service better then I

[katbyte]

Thanks for the review @francescopersico! really appreciate the info on how the scope changed worked. i'll see about getting this in today

[jackofallops]

Mostly looking fine, but a couple of concerns and I suspect the acctests, still running at time of writing this, are going to fail due to the ID path elements I've commented on.

[mbfrahry]

LGTM!

[ghost]

This has been released in version 2.7.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.7.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!