d/azurerm_kubernetes_cluster extended with kubelet_identity and identity #6527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
aristosvo
changed the title
aristosvo
changed the title
tombuildsstuff
requested changes
Apr 21, 2020
There was a problem hiding this comment.
hey @aristosvo
Thanks for this PR :)
Taking a look through this mostly LGTM - if we can fix up the comments then this should otherwise be good to merge 👍
Thanks!
azurerm/internal/services/containers/data_source_kubernetes_cluster.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/containers/data_source_kubernetes_cluster.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/containers/data_source_kubernetes_cluster.go
Outdated
Show resolved
Hide resolved
|
Comments implemented! |
tombuildsstuff
approved these changes
May 25, 2020
katbyte
added a commit
that referenced
this pull request
May 25, 2020
pbrit
pushed a commit
to pbrit/terraform-provider-azurerm
that referenced
this pull request
May 31, 2020
…ity (hashicorp#6527) Co-authored-by: kt <kt@katbyte.me> Fixes hashicorp#6514
pbrit
pushed a commit
to pbrit/terraform-provider-azurerm
that referenced
this pull request
May 31, 2020
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6514