Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_virtual_network_gateway_connection - shared_key is optional when type is IPSec #6565

Merged
merged 3 commits into from Apr 26, 2020
Merged

azurerm_virtual_network_gateway_connection - shared_key is optional when type is IPSec #6565

merged 3 commits into from Apr 26, 2020

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Apr 21, 2020 •
edited

fixes #5402

tombuildsstuff
tombuildsstuff reviewed Apr 21, 2020
View reviewed changes
azurerm/internal/services/network/resource_arm_virtual_network_gateway_connection.go
return nil, fmt.Errorf("`local_network_gateway_id` and `shared_key` must be specified when `type` is set to `IPsec")
}

if props.SharedKey == nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add an acceptance test to ensure this use-case is supported through the API? Unfortunately ARM Templates can behave differently to the API's themselves - so an acceptance test should confirm this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@ghost ghost added size/M and removed size/XS labels Apr 22, 2020
@neil-yechenwei
Copy link
Contributor Author

@tombuildsstuff , Thanks for your suggestion. I've added test case to cover this use-case.

@ghost ghost removed the waiting-response label Apr 22, 2020
@katbyte katbyte changed the title Update shared_key as optional when type is IPSec azurerm_virtual_network_gateway_connection - shared_key is optional when type is IPSec Apr 26, 2020
@katbyte katbyte added this to the v2.8.0 milestone Apr 26, 2020
katbyte
katbyte approved these changes Apr 26, 2020
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neil-yechenwei, LGTM 👍

@katbyte katbyte merged commit ffb2046 into hashicorp:master Apr 26, 2020
katbyte added a commit that referenced this pull request Apr 26, 2020
@katbyte
update CHANGELOG.md to include #6565
4002487
@ghost
Copy link

ghost commented May 1, 2020

This has been released in version 2.8.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.8.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators May 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff left review comments

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation service/virtual-network-gateway size/M
Projects
None yet
Milestone
v2.8.0
Development

Successfully merging this pull request may close these issues.

Make shared_key optional when type is IPSec
3 participants
@neil-yechenwei @tombuildsstuff @katbyte