Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource/Data source azurerm_data_share_account #6575

Merged
merged 4 commits into from May 5, 2020

Conversation

yupwei68
Copy link
Contributor

fix #6480

datashare account

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr @yupwei68! aside from a few comments i've left inline this is looking pretty good. Once they are addressed should be good to merge!

@yupwei68 yupwei68 requested a review from katbyte April 30, 2020 03:33
@yupwei68
Copy link
Contributor Author

Hi @katbyte Sure! Corresponding changes are pushed

@katbyte katbyte modified the milestones: v2.8.0, v2.9.0 Apr 30, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yupwei68! LGTM 👍

@katbyte katbyte merged commit 78074c8 into hashicorp:master May 5, 2020
katbyte added a commit that referenced this pull request May 5, 2020
@ghost
Copy link

ghost commented May 8, 2020

This has been released in version 2.9.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.9.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jun 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for [Data Share]
2 participants