Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_redis_cache - correctly build connection strings when SSL is disabled #6635

Merged
merged 1 commit into from Apr 29, 2020

Conversation

maxbog
Copy link
Contributor

@maxbog maxbog commented Apr 27, 2020

Fixes #6279

@ghost ghost added the size/M label Apr 27, 2020
@maxbog maxbog force-pushed the f/fix_redis_ssl_connection_string branch 2 times, most recently from aff8433 to 1f1d29f Compare April 27, 2020 14:09
@maxbog maxbog force-pushed the f/fix_redis_ssl_connection_string branch from 1f1d29f to d313ee1 Compare April 27, 2020 21:26
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix @maxbog! LGTM 👍

@katbyte katbyte added this to the v2.8.0 milestone Apr 29, 2020
@katbyte katbyte changed the title azurerm_redis_cache - Fix ssl setting for Redis connection strings azurerm_redis_cache - correctly build connection strings when SSL is disabled Apr 29, 2020
@katbyte katbyte merged commit 0aa1eca into hashicorp:master Apr 29, 2020
katbyte added a commit that referenced this pull request Apr 29, 2020
@ghost
Copy link

ghost commented May 1, 2020

This has been released in version 2.8.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.8.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators May 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_redis_cache: sll in primary and secondary connection string is wrong
2 participants