VM and VMSS validation fixes #6639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r names - Adjust naming rules to meet current API behavior - Length validation for VMSS computer name prefixes
ghost
added
katbyte
approved these changes
Apr 28, 2020
azurerm/internal/services/compute/linux_virtual_machine_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/compute/resource_arm_linux_virtual_machine_scale_set.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/compute/resource_arm_windows_virtual_machine_scale_set.go
Outdated
Show resolved
Hide resolved
Fixed, thanks for catching! |
|
This has been released in version 2.8.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.8.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate validation for VM/VMSS (resource) name, and linux/windows computer names
This maintains the current behavior of assuming the
computer_name/computer_name_prefixfrom the VM / VMSS name respectively. However since thenamevalues now have more relaxed rules, should the specifiednamenot be a validcomputer_name/computer_name_prefix, then the latter must also be specified. There are new tests for these cases.