Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: azurerm_sentinel_alert_rule_scheduled #6650

Merged

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Apr 27, 2020

This PR implement one of the alert rule resource required in #6448.

Test Result

💤 😡 2 via 🦉 v1.14.2 make testacc TEST=./azurerm/internal/services/sentinel/tests TESTARGS="-run='TestAccAzureRMSentinelAlertRuleScheduled_'"
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
TF_ACC=1 go test ./azurerm/internal/services/sentinel/tests -v -run='TestAccAzureRMSentinelAlertRuleScheduled_' -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMSentinelAlertRuleScheduled_basic
=== PAUSE TestAccAzureRMSentinelAlertRuleScheduled_basic
=== RUN   TestAccAzureRMSentinelAlertRuleScheduled_complete
=== PAUSE TestAccAzureRMSentinelAlertRuleScheduled_complete
=== RUN   TestAccAzureRMSentinelAlertRuleScheduled_update
=== PAUSE TestAccAzureRMSentinelAlertRuleScheduled_update
=== RUN   TestAccAzureRMSentinelAlertRuleScheduled_requiresImport
=== PAUSE TestAccAzureRMSentinelAlertRuleScheduled_requiresImport
=== CONT  TestAccAzureRMSentinelAlertRuleScheduled_basic
=== CONT  TestAccAzureRMSentinelAlertRuleScheduled_requiresImport
=== CONT  TestAccAzureRMSentinelAlertRuleScheduled_update
=== CONT  TestAccAzureRMSentinelAlertRuleScheduled_complete
--- PASS: TestAccAzureRMSentinelAlertRuleScheduled_complete (160.37s)
--- PASS: TestAccAzureRMSentinelAlertRuleScheduled_basic (175.11s)
--- PASS: TestAccAzureRMSentinelAlertRuleScheduled_requiresImport (186.62s)
--- PASS: TestAccAzureRMSentinelAlertRuleScheduled_update (298.21s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/sentinel/tests      298.251s

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @magodo, this looks great. Just a minor thing around checking for an error when setting a List/Set

@mbfrahry mbfrahry modified the milestones: v2.10.0, v2.9.0 May 6, 2020
@magodo
Copy link
Collaborator Author

magodo commented May 7, 2020

@mbfrahry Thank you! I have updated the code accordingly!

@magodo magodo requested a review from mbfrahry May 7, 2020 03:35
@mbfrahry mbfrahry changed the title new resource: azurerm_sentinel_alert_rule_scheduled New resource: azurerm_sentinel_alert_rule_scheduled May 7, 2020
@mbfrahry mbfrahry merged commit 9498ad8 into hashicorp:master May 7, 2020
mbfrahry added a commit that referenced this pull request May 7, 2020
@ghost
Copy link

ghost commented May 8, 2020

This has been released in version 2.9.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.9.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jun 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants