Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_api_management_diagnostic - support required property api_management_logger_id #6682

Merged
merged 9 commits into from May 14, 2020

Conversation

yupwei68
Copy link
Contributor

@yupwei68 yupwei68 commented Apr 29, 2020

fix #6619

This will be a breaking change for it adds a required field "logger_id"

=== RUN TestAccAzureRMApiManagementDiagnostic_basic
=== PAUSE TestAccAzureRMApiManagementDiagnostic_basic
=== CONT TestAccAzureRMApiManagementDiagnostic_basic
--- PASS: TestAccAzureRMApiManagementDiagnostic_basic (2498.17s)
=== RUN TestAccAzureRMApiManagementDiagnostic_update
=== PAUSE TestAccAzureRMApiManagementDiagnostic_update
=== CONT TestAccAzureRMApiManagementDiagnostic_update
--- PASS: TestAccAzureRMApiManagementDiagnostic_update (2566.13s)
=== RUN TestAccAzureRMApiManagementDiagnostic_requiresImport
=== PAUSE TestAccAzureRMApiManagementDiagnostic_requiresImport
=== CONT TestAccAzureRMApiManagementDiagnostic_requiresImport
--- PASS: TestAccAzureRMApiManagementDiagnostic_requiresImport (2330.79s)
PASS

(also fixes #6104)

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @yupwei68! LGTM aside from i think the property should be api_management_logger_id to be explicit what's required. hope you don't mind but i've pushed that change so we can get this released in 2.10.

@katbyte katbyte added this to the v2.10.0 milestone May 14, 2020
@katbyte katbyte changed the title Fix regression problem of azurerm_api_management_diagnostic azurerm_api_management_diagnostic - support required property api_management_logger_id May 14, 2020
@katbyte katbyte merged commit 00aaff2 into hashicorp:master May 14, 2020
katbyte added a commit that referenced this pull request May 14, 2020
@ghost
Copy link

ghost commented May 15, 2020

This has been released in version 2.10.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.10.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jun 14, 2020
@yupwei68 yupwei68 deleted the wyp-apim-issue branch July 10, 2020 02:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_api_management_diagnostic fails after 2.7.0 azurerm_api_management_diagnostic doesn't link to logger
3 participants