Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recovery capability for Key Vault Soft Deleted Keys, Secrets and Certificates #6716

Merged
merged 6 commits into from May 1, 2020

Conversation

jackofallops
Copy link
Member

Adds support for recovering Soft Deleted items from KeyVault. This feature is toggled by the recover_soft_deleted_key_vaults setting the Provider's feature config.

This requires that Terraform has the recover permission on the item type in the KeyVault.

@jackofallops jackofallops added this to the v2.8.0 milestone Apr 30, 2020
@jackofallops jackofallops requested a review from a team April 30, 2020 15:48
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jackofallops! LGTM 👍

@katbyte katbyte modified the milestones: v2.8.0, v2.9.0 Apr 30, 2020
@jackofallops
Copy link
Member Author

Tests pass:
image
And the one failed also fixed:
image

@jackofallops jackofallops merged commit e937dc6 into master May 1, 2020
@jackofallops jackofallops deleted the f/kv-soft-delete-child-recovery branch May 1, 2020 12:34
jackofallops added a commit that referenced this pull request May 1, 2020
tombuildsstuff added a commit that referenced this pull request May 4, 2020
@ghost
Copy link

ghost commented May 8, 2020

This has been released in version 2.9.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.9.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators May 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants