Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the Developer Portal type of hostname_configuration in azurerm_api_management #6724

Merged
merged 1 commit into from May 13, 2020

Conversation

sirlatrom
Copy link
Contributor

Fixes #6714.

Comment on lines 523 to 527
developer_portal {
host_name = "developer-portal.terraform.io"
certificate = filebase64("testdata/api_management_developer_portal_test.pfx")
certificate_password = "terraform"
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note the requirement of an additional hostname (please advise if it should be changed to a different one) and a certificate file in testdata/.

@sirlatrom
Copy link
Contributor Author

@katbyte As with previous PRs, I've not been able to run acceptance tests but have verified functionality within my org's tenant.

…m_api_management

Signed-off-by: Sune Keller <absukl@almbrand.dk>
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @sirlatrom! LGTM 👍

@katbyte katbyte merged commit 8ff0f58 into hashicorp:master May 13, 2020
katbyte added a commit that referenced this pull request May 13, 2020
@sirlatrom sirlatrom deleted the fix-6714 branch May 13, 2020 23:52
@ghost
Copy link

ghost commented May 15, 2020

This has been released in version 2.10.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.10.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for new Developer Portal in APIM hostname_configuration block
2 participants