Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: upgrade azure-sdk-for-go to v42.1.0 & azuread to v0.9.0 #6725

Merged
merged 1 commit into from May 17, 2020

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented May 1, 2020

No description provided.

@katbyte katbyte added this to the v2.9.0 milestone May 1, 2020
@katbyte katbyte requested a review from a team May 1, 2020 00:39
@ghost ghost added the size/XXL label May 1, 2020
@katbyte
Copy link
Collaborator Author

katbyte commented May 1, 2020

It looks like databricks public ip is miss or has been removed from the API:

../services/databricks/resource_arm_databricks_workspace.go:270:11: p.EnableNoPublicIP undefined (type *databricks.WorkspaceCustomParameters has no field or method EnableNoPublicIP)
../services/databricks/resource_arm_databricks_workspace.go:306:13: parameters.EnableNoPublicIP undefined (type databricks.WorkspaceCustomParameters has no field or method EnableNoPublicIP)

Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@katbyte katbyte force-pushed the kt/hitchhikers-guide-to-sdk-v42 branch from 83b3636 to fee83cc Compare May 15, 2020 05:33
@katbyte katbyte changed the title provider: upgrade azure-sdk-for-go to v42.0.0 provider: upgrade azure-sdk-for-go to v42.1.0 & azuread to v0.9.0 May 15, 2020
@katbyte katbyte merged commit ccdbf2f into master May 17, 2020
@katbyte katbyte deleted the kt/hitchhikers-guide-to-sdk-v42 branch May 17, 2020 07:09
katbyte added a commit that referenced this pull request May 17, 2020
@ghost
Copy link

ghost commented May 22, 2020

This has been released in version 2.11.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.11.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 16, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jun 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants