Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support create option for scale set data disks #6744

Merged
merged 1 commit into from May 4, 2020

Conversation

hbuckle
Copy link
Contributor

@hbuckle hbuckle commented May 2, 2020

If you use a custom image that includes data disks you need to specify them as FromImage

Example:

  # This comes from the source image
  data_disk {
    storage_account_type = "Standard_LRS"
    caching              = "ReadWrite"
    lun                  = 0
    disk_size_gb         = 10
    create_option        = "FromImage"
  }

  # This is an additional disk
  data_disk {
    storage_account_type = "Premium_LRS"
    caching              = "ReadWrite"
    lun                  = 1
    disk_size_gb         = 50
    create_option        = "Empty"
  }

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @hbuckle

@tombuildsstuff tombuildsstuff added this to the v2.9.0 milestone May 4, 2020
@tombuildsstuff tombuildsstuff merged commit 2e5b100 into hashicorp:master May 4, 2020
@tombuildsstuff tombuildsstuff added the service/vmss Virtual Machine Scale Sets label May 4, 2020
tombuildsstuff added a commit that referenced this pull request May 4, 2020
@ghost
Copy link

ghost commented May 8, 2020

This has been released in version 2.9.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.9.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jun 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants