Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for strange response code in recovery services network mappings API. Fixes issue #6026 #6747

Conversation

martenbohlin
Copy link
Contributor

Issue #6026 seems to be caused by the Azure API returning 400 instead of 404 when there are no network-mapping with the name that we ask for. This pull requests adds a workaround for that.

(Is there a way for me to report a bug on the API?)

@ghost ghost added the size/XS label May 3, 2020
@katbyte
Copy link
Collaborator

katbyte commented May 3, 2020

@martenbohlin - what we typically do is open an issue on the azure-sdk-for gorepo, and then place a link in an comment next to the work aaround so we know why, and can easily check to see if its fixed.

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @martenbohlin

@tombuildsstuff tombuildsstuff added this to the v2.9.0 milestone May 6, 2020
@tombuildsstuff
Copy link
Member

Test passes:

Uploading Screenshot 2020-05-06 at 12.53.12.png…

@ghost
Copy link

ghost commented May 8, 2020

This has been released in version 2.9.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.9.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jun 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants