Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Allow updating Analysis Services Server when paused #6786

Conversation

r0bnet
Copy link
Contributor

@r0bnet r0bnet commented May 6, 2020

This PR checks if the Analysis Services Server is paused when it's going to be updated and will start it before. It will also suspend it again afterwards if needed.

Before it was unable to update a paused Analysis Services Server.

@ghost ghost added the size/S label May 6, 2020
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @r0bnet

Thanks for this PR - taking a look through this is looking good - if we can fix up the minor comments and add an acceptance test then this otherwise LGTM 👍

Thanks!

@ghost ghost added size/M and removed size/S labels May 6, 2020
@r0bnet
Copy link
Contributor Author

r0bnet commented May 6, 2020

@tombuildsstuff added an acceptance test and fixed your comments.

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Member

Tests pass:

Screenshot 2020-05-07 at 11 21 31

@tombuildsstuff tombuildsstuff merged commit 3f07b5a into hashicorp:master May 7, 2020
tombuildsstuff added a commit that referenced this pull request May 7, 2020
@ghost
Copy link

ghost commented May 8, 2020

This has been released in version 2.9.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.9.0"
}
# ... other configuration ...

@r0bnet r0bnet deleted the analysis-services-server-update-when-paused branch May 28, 2020 13:24
@ghost
Copy link

ghost commented Jun 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jun 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants