New resource/Data Source azurerm_data_share

[yupwei68]

fix #6480

[katbyte]

Thanks for the PR @yupwei68, overall this looks good with my main concern not exposing the snapshot's name in the block or to the user.

[yupwei68]

@katbyte , except read method still uses listcomplete for ImportStateVerify error, the createUpdate and delete method have changed. Please continue reviewing.

=== RUN   TestAccAzureRMDataShare_basic
=== PAUSE TestAccAzureRMDataShare_basic
=== CONT  TestAccAzureRMDataShare_basic
--- PASS: TestAccAzureRMDataShare_basic (352.64s)
=== RUN   TestAccAzureRMDataShare_requiresImport
=== PAUSE TestAccAzureRMDataShare_requiresImport
=== CONT  TestAccAzureRMDataShare_requiresImport
--- PASS: TestAccAzureRMDataShare_requiresImport (356.65s)
=== RUN   TestAccAzureRMDataShare_complete
=== PAUSE TestAccAzureRMDataShare_complete
=== CONT  TestAccAzureRMDataShare_complete
--- PASS: TestAccAzureRMDataShare_complete (351.99s)
=== RUN   TestAccAzureRMDataShare_update
=== PAUSE TestAccAzureRMDataShare_update
=== CONT  TestAccAzureRMDataShare_update
--- PASS: TestAccAzureRMDataShare_update (418.62s)
=== RUN   TestAccAzureRMDataShare_snapshotSchedule
=== PAUSE TestAccAzureRMDataShare_snapshotSchedule
=== CONT  TestAccAzureRMDataShare_snapshotSchedule
--- PASS: TestAccAzureRMDataShare_snapshotSchedule (604.38s)
PASS

[katbyte]

thanks for the changes @yupwei68. Aside for a few comments i've left inline this is looking good.

It also looks like there is a failing test:

 TestAccDataSourceAzureRMDataShare_snapshotSchedule: testing.go:640: Step 1 error: 3 problems:
        
        - Provider produced invalid object: Provider "azurerm" planned an invalid value for data.azurerm_data_share.test during refresh: .timeouts: unsupported attribute "update".
        
        This is a bug in the provider, which should be reported in the provider's own issue tracker.
        - Provider produced invalid object: Provider "azurerm" planned an invalid value for data.azurerm_data_share.test during refresh: .timeouts: unsupported attribute "create".
        
        This is a bug in the provider, which should be reported in the provider's own issue tracker.
        - Provider produced invalid object: Provider "azurerm" planned an invalid value for data.azurerm_data_share.test during refresh: .timeouts: unsupported attribute "delete".
        

[yupwei68]

Hi @katbyte ,thanks for your comments. Except one concern, corresponding changes have been pushed. Please continue reviewing.

resource_test

=== RUN   TestAccAzureRMDataShare_basic
=== PAUSE TestAccAzureRMDataShare_basic
=== CONT  TestAccAzureRMDataShare_basic
--- PASS: TestAccAzureRMDataShare_basic (352.89s)
=== RUN   TestAccAzureRMDataShare_requiresImport
=== PAUSE TestAccAzureRMDataShare_requiresImport
=== CONT  TestAccAzureRMDataShare_requiresImport
--- PASS: TestAccAzureRMDataShare_requiresImport (360.01s)
=== RUN   TestAccAzureRMDataShare_complete
=== PAUSE TestAccAzureRMDataShare_complete
=== CONT  TestAccAzureRMDataShare_complete
--- PASS: TestAccAzureRMDataShare_complete (352.88s)
=== RUN   TestAccAzureRMDataShare_update
=== PAUSE TestAccAzureRMDataShare_update
=== CONT  TestAccAzureRMDataShare_update
--- PASS: TestAccAzureRMDataShare_update (434.55s)
=== RUN   TestAccAzureRMDataShare_snapshotSchedule
=== PAUSE TestAccAzureRMDataShare_snapshotSchedule
=== CONT  TestAccAzureRMDataShare_snapshotSchedule
--- PASS: TestAccAzureRMDataShare_snapshotSchedule (604.04s)

data_source_test

=== RUN   TestAccDataSourceAzureRMDataShare_basic
=== PAUSE TestAccDataSourceAzureRMDataShare_basic
=== CONT  TestAccDataSourceAzureRMDataShare_basic
--- PASS: TestAccDataSourceAzureRMDataShare_basic (359.62s)
=== RUN   TestAccDataSourceAzureRMDataShare_snapshotSchedule
=== PAUSE TestAccDataSourceAzureRMDataShare_snapshotSchedule
=== CONT  TestAccDataSourceAzureRMDataShare_snapshotSchedule
--- PASS: TestAccDataSourceAzureRMDataShare_snapshotSchedule (432.83s)

[katbyte]

thanks @yupwei68! LGTM 👍

[ghost]

This has been released in version 2.11.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.11.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!