Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_mssql_server - Add support for azuread_administrator #6822

Merged
merged 7 commits into from May 8, 2020

Conversation

yupwei68
Copy link
Contributor

@yupwei68 yupwei68 commented May 8, 2020

Fix #6559
=== RUN TestAccAzureRMMsSqlServer_azureadAdmin
=== PAUSE TestAccAzureRMMsSqlServer_azureadAdmin
=== CONT TestAccAzureRMMsSqlServer_azureadAdmin
--- PASS: TestAccAzureRMMsSqlServer_azureadAdmin (344.58s)
PASS
=== RUN TestAccAzureRMMsSqlServer_blobAuditingPolicies_withFirewall
=== PAUSE TestAccAzureRMMsSqlServer_blobAuditingPolicies_withFirewall
=== CONT TestAccAzureRMMsSqlServer_blobAuditingPolicies_withFirewall
--- PASS: TestAccAzureRMMsSqlServer_blobAuditingPolicies_withFirewall (390.31s)
PASS

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this @yupwei68

@mbfrahry mbfrahry changed the title Add block azuread_administrator in azurerm_mssql_server azurerm_mssql_server - Add support for azuread_administrator May 8, 2020
@mbfrahry mbfrahry merged commit 745543c into hashicorp:master May 8, 2020
mbfrahry added a commit that referenced this pull request May 8, 2020
@mbfrahry mbfrahry added service/mssql Microsoft SQL Server enhancement labels May 8, 2020
@mbfrahry mbfrahry added this to the v2.10.0 milestone May 8, 2020
@ghost
Copy link

ghost commented May 15, 2020

This has been released in version 2.10.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.10.0"
}
# ... other configuration ...

@hashitop
Copy link
Contributor

@yupwei68 @mbfrahry could you review comments here and advise.

It does not seems to work when setting default action of the network_rules on storage account to Deny with bypass list but the steps in the reference document work OK.

@ghost
Copy link

ghost commented Jun 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jun 8, 2020
@yupwei68 yupwei68 deleted the wyp-sql-server branch July 10, 2020 02:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sql server auditing policies fail to be set with storage account with firewall or vn
3 participants