Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_api_management_named_value - fix the non empty plan when secret is true #6834

Merged
merged 6 commits into from May 12, 2020

Conversation

yupwei68
Copy link
Contributor

@yupwei68 yupwei68 commented May 9, 2020

Fix #6688

image

@ghost ghost added the size/XS label May 9, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yupwei68,

however you may need to change the logic to pull the value across reads as there is a failing test:

 TestAccAzureRMAPIManagementNamedValue_update: testing.go:640: Step 1 error: After applying this step, the plan was not empty:
        
        DIFF:
        
        UPDATE: azurerm_api_management_named_value.test
          api_management_name: "acctestAM-200511194826164695" => "acctestAM-200511194826164695"
          display_name:        "TestProperty200511194826164695" => "TestProperty2200511194826164695"
          id:                  "/subscriptions/1a6092a6-137e-4025-9a7c-ef77f76f2c02/resourceGroups/acctestRG-200511194826164695/providers/Microsoft.ApiManagement/service/acctestAM-200511194826164695/namedValues/acctestAMProperty-200511194826164695" => "/subscriptions/1a6092a6-137e-4025-9a7c-ef77f76f2c02/resourceGroups/acctestRG-200511194826164695/providers/Microsoft.ApiManagement/service/acctestAM-200511194826164695/namedValues/acctestAMProperty-200511194826164695"
          name:                "acctestAMProperty-200511194826164695" => "acctestAMProperty-200511194826164695"
          resource_group_name: "acctestRG-200511194826164695" => "acctestRG-200511194826164695"
          secret:              "false" => "true"
          tags.#:              "2" => "2"
          tags.0:              "tag1" => "tag3"
          tags.1:              "tag2" => "tag4"
          value:               "Test Value" => "Test Value2"

@yupwei68
Copy link
Contributor Author

Hi @katbyte, I don't know why. I still get tests passed.
image

@ghost ghost removed the waiting-response label May 12, 2020
@katbyte katbyte added this to the v2.10.0 milestone May 12, 2020
@katbyte katbyte changed the title Fix azurerm_api_management_named_value plan is not empty azurerm_api_management_named_value - fix the non empty plan when secret is true May 12, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yupwei68, tests pass now 👍

@katbyte katbyte merged commit 3828e74 into hashicorp:master May 12, 2020
katbyte added a commit that referenced this pull request May 12, 2020
@ghost
Copy link

ghost commented May 15, 2020

This has been released in version 2.10.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.10.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jun 12, 2020
@yupwei68 yupwei68 deleted the wyp-apim-namedvalue branch July 10, 2020 02:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_api_management_named_value consistently creating "value" resource attribute ignoring state file
2 participants