Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New data source azurerm_eventhub #6841

Merged
merged 6 commits into from May 11, 2020
Merged

New data source azurerm_eventhub #6841

merged 6 commits into from May 11, 2020

Conversation

robselway
Copy link
Contributor

Fixes #6460

tombuildsstuff
tombuildsstuff reviewed May 11, 2020
View reviewed changes
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @robselway

Thanks for this PR :)

Taking a look through here this mostly LGTM - if we can swap the Set to a List then we should be able to run the tests and get this merged 👍

Thanks!

azurerm/internal/services/eventhub/eventhub_data_source.go Outdated Show resolved Hide resolved
azurerm/internal/services/eventhub/eventhub_data_source.go Outdated Show resolved Hide resolved
@robselway
Copy link
Contributor Author

Thanks @tombuildsstuff - done :)

@ghost ghost removed the waiting-response label May 11, 2020
@tombuildsstuff tombuildsstuff modified the milestones: v2.11.0, v2.10.0 May 11, 2020
@tombuildsstuff
Copy link
Member

Tests pass:

Screenshot 2020-05-11 at 17 47 08

@tombuildsstuff tombuildsstuff merged commit a1ad233 into hashicorp:master May 11, 2020
tombuildsstuff added a commit that referenced this pull request May 11, 2020
@tombuildsstuff
updating to include #6841
98087b3
jrauschenbusch pushed a commit to jrauschenbusch/terraform-provider-azurerm that referenced this pull request May 13, 2020
@tombuildsstuff @jrauschenbusch
updating to include hashicorp#6841
ece5923
@ghost
Copy link

ghost commented May 15, 2020

This has been released in version 2.10.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.10.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jun 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff left review comments

Assignees
No one assigned
Labels
documentation new-data-source service/event-hubs EventHubs size/L
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging this pull request may close these issues.

Support for azurerm_eventhub data source
2 participants
@robselway @tombuildsstuff