Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_log_analytics_workspace - Support rentention_in_days for Free Tier #6844

Merged

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented May 11, 2020

Fixes #6764

Test Result

💤 via 🦉 v1.14.2 make testacc TEST=./azurerm/internal/services/loganalytics/tests TESTARGS="-run TestAccAzureRMLogAnalyticsWorkspace_freeTier"
==> Checking that code complies with gofmt requirements...                                                                                   
==> Checking that Custom Timeouts are used...                                                                                                
TF_ACC=1 go test ./azurerm/internal/services/loganalytics/tests -v -run TestAccAzureRMLogAnalyticsWorkspace_freeTier -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMLogAnalyticsWorkspace_freeTier                                                                                       
=== PAUSE TestAccAzureRMLogAnalyticsWorkspace_freeTier                                                                                       
=== CONT  TestAccAzureRMLogAnalyticsWorkspace_freeTier                                                                                       
--- PASS: TestAccAzureRMLogAnalyticsWorkspace_freeTier (248.29s)                                                                             
PASS                                                                                                                                         
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/loganalytics/tests  248.309s  

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry added this to the v2.10.0 milestone May 12, 2020
@mbfrahry mbfrahry changed the title azurerm_log_analytics_workspace rentention_in_days consider Free Tier azurerm_log_analytics_workspace - Support rentention_in_days for Free Tier May 12, 2020
@mbfrahry mbfrahry merged commit a99bfcb into hashicorp:master May 12, 2020
mbfrahry added a commit that referenced this pull request May 12, 2020
@ghost
Copy link

ghost commented May 15, 2020

This has been released in version 2.10.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.10.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jun 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_log_analytics_workspace Free sku with 7 days of data retention
2 participants