Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data source azurerm_management_group - support get data source of mgmt group by using display_name #6845

Merged
merged 6 commits into from Jun 17, 2020

Conversation

ArcturusZhang
Copy link
Contributor

Fixes #6757

@ArcturusZhang ArcturusZhang changed the title Update resource and data source azurerm_management_group - support get data source of mgmt group by using display_name Update data source azurerm_management_group - support get data source of mgmt group by using display_name May 11, 2020
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @ArcturusZhang

Thanks for this PR - taking a look through this mostly LGTM - if we can fix up the remaining comments then this should otherwise be good to merge 👍

Thanks!

@ArcturusZhang
Copy link
Contributor Author

Hi @tombuildsstuff I have resolved the comments, please have a look.
As for the import step, I suppose data source test cannot add import steps (which will lead to errors). I did an experiment with the data source test of dedicated host.

@katbyte katbyte added this to the v2.15.0 milestone Jun 17, 2020
@katbyte katbyte merged commit c969611 into hashicorp:master Jun 17, 2020
katbyte added a commit that referenced this pull request Jun 17, 2020
@ArcturusZhang ArcturusZhang deleted the fix-6757 branch June 18, 2020 05:17
@ghost
Copy link

ghost commented Jun 19, 2020

This has been released in version 2.15.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.15.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jul 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_management_group validation should allow spaces
3 participants