Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_windows_virtual_machine - Allow update of OS disk encryption settings #6846

Merged
merged 1 commit into from May 11, 2020

Conversation

ArcturusZhang
Copy link
Contributor

@ArcturusZhang ArcturusZhang commented May 11, 2020

Fixes #6737

This applies the changes in PR #6230 to windows virtual machine which only fixes the problem in linux virtual machine despite its title says linux|windows.

Acc tests passing:
image

@ghost ghost added the size/M label May 11, 2020
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added this to the v2.10.0 milestone May 11, 2020
@katbyte katbyte merged commit 482bc67 into hashicorp:master May 11, 2020
katbyte added a commit that referenced this pull request May 11, 2020
@ArcturusZhang ArcturusZhang deleted the fix-6737 branch May 12, 2020 00:10
jrauschenbusch pushed a commit to jrauschenbusch/terraform-provider-azurerm that referenced this pull request May 13, 2020
…n settings (hashicorp#6846)

Fixes hashicorp#6737

This applies the changes in PR hashicorp#6230 to windows virtual machine which only fixes the problem in linux virtual machine despite its title says linux|windows.
jrauschenbusch pushed a commit to jrauschenbusch/terraform-provider-azurerm that referenced this pull request May 13, 2020
@ghost
Copy link

ghost commented May 15, 2020

This has been released in version 2.10.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.10.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jun 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows OS disk encryption (disk encryption set) cannot be updated after VM is created
3 participants