Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: eventgrid id parsers #6958

Merged
merged 1 commit into from May 20, 2020
Merged

fix: eventgrid id parsers #6958

merged 1 commit into from May 20, 2020

Conversation

jrauschenbusch
Copy link
Contributor

@jrauschenbusch jrauschenbusch commented May 15, 2020 •
edited

Fixes #6952
Fixes #6962

Including tests for the other parsers

@ghost ghost added the size/L label May 15, 2020
@jrauschenbusch jrauschenbusch mentioned this pull request May 16, 2020
Closed
@jrauschenbusch
Copy link
Contributor Author

@katbyte CI steps failed, but imho due to runner issues. I think this hotfix is important, as currently EventGrid event subscriptions are broken. If there are tests missing please let me know.

tombuildsstuff
tombuildsstuff approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @jrauschenbusch

@tombuildsstuff
Copy link
Member

@jrauschenbusch agreed this looks like a Travis/GH issue - I've re-triggered Travis

@tombuildsstuff tombuildsstuff added this to the v2.11.0 milestone May 20, 2020
@tombuildsstuff
Copy link
Member

Acceptance tests look good 👍

@tombuildsstuff tombuildsstuff merged commit 41c524e into hashicorp:master May 20, 2020
tombuildsstuff added a commit that referenced this pull request May 20, 2020
@tombuildsstuff
updating to include #6958
ea4e362
@ghost
Copy link

ghost commented May 22, 2020

This has been released in version 2.11.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.11.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jun 19, 2020
@jrauschenbusch jrauschenbusch deleted the fix-eventgrid-subscription-id-parser branch July 9, 2020 05:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
bug service/event-grid EventGrid size/L
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging this pull request may close these issues.

EventGrid subscriptions throwing error in v2.10.0 Support for eventgrid_domain_subscription
2 participants
@jrauschenbusch @tombuildsstuff