Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_app_service Added support for Action of Allow or Deny in ip_restriction. #6967

Merged
merged 6 commits into from May 20, 2020
Merged

azurerm_app_service Added support for Action of Allow or Deny in ip_restriction. #6967

merged 6 commits into from May 20, 2020

Conversation

SebRosander
Copy link
Contributor

Fixes #6900

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this pr @SebRosander! aside from one comment (which i will push a change for) this LGTM 👍

azurerm/helpers/azure/app_service.go Outdated Show resolved Hide resolved
@katbyte katbyte added this to the v2.11.0 milestone May 20, 2020
@katbyte katbyte merged commit 7c5a78c into hashicorp:master May 20, 2020
katbyte added a commit that referenced this pull request May 20, 2020
@ghost
Copy link

ghost commented May 22, 2020

This has been released in version 2.11.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.11.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jun 19, 2020
@SebRosander SebRosander deleted the issue-6900 branch June 20, 2020 16:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Action of Allow or Deny in ip_restriction of azurerm_app_service
2 participants