Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Sources should error when not found #7024

Merged
merged 13 commits into from May 20, 2020
Merged

Data Sources should error when not found #7024

merged 13 commits into from May 20, 2020

Conversation

tombuildsstuff
Copy link
Member

Fixes #7009

@tombuildsstuff tombuildsstuff added this to the v2.11.0 milestone May 20, 2020
@tombuildsstuff tombuildsstuff requested a review from a team May 20, 2020 09:48
@ghost ghost added the size/L label May 20, 2020
@tombuildsstuff tombuildsstuff mentioned this pull request May 20, 2020
Closed
jackofallops
jackofallops approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tombuildsstuff
There's a few return fmt.Errorf("Error in there, but otherwise LGTM 👍

@tombuildsstuff tombuildsstuff merged commit e0e07af into master May 20, 2020
@tombuildsstuff tombuildsstuff deleted the b/data-sources-should-error-on-404 branch May 20, 2020 13:08
tombuildsstuff added a commit that referenced this pull request May 20, 2020
@tombuildsstuff
updating to include #7024
04bae6d
@ghost
Copy link

ghost commented May 22, 2020

This has been released in version 2.11.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.11.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackofallops jackofallops jackofallops approved these changes

Assignees
No one assigned
Labels
bug size/L
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging this pull request may close these issues.

Error: "principal_id": required field is not set - for azurerm_role_assignment
2 participants
@tombuildsstuff @jackofallops