Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix azurerm_orchestrated_virtual_machine_scale_set - azurerm_linux|windows_virtual_machine should allow to assign virtual_machine_scale_set_id in non-zonal deployment #7057

Merged
merged 2 commits into from May 24, 2020

Conversation

ArcturusZhang
Copy link
Contributor

The zone in azurerm_linux|windows_virtual_machine should be allowed to be empty when the virtual_machine_scale_set_id is assigned, since the VMSS referenced by the VM can be deployed non-zonal.

@ghost ghost added the size/XL label May 23, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArcturusZhang, LGTM 👍

@katbyte katbyte added this to the v2.12.0 milestone May 24, 2020
@katbyte katbyte merged commit 00f95f0 into hashicorp:master May 24, 2020
katbyte added a commit that referenced this pull request May 24, 2020
@ArcturusZhang ArcturusZhang deleted the fix-orchestration-mode branch May 25, 2020 02:20
@ghost
Copy link

ghost commented May 28, 2020

This has been released in version 2.12.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.12.0"
}
# ... other configuration ...

pbrit pushed a commit to pbrit/terraform-provider-azurerm that referenced this pull request May 31, 2020
…|windows_virtual_machine` should allow to assign `virtual_machine_scale_set_id` in non-zonal deployment (hashicorp#7057)

The zone in azurerm_linux|windows_virtual_machine should be allowed to be empty when the virtual_machine_scale_set_id is assigned, since the VMSS referenced by the VM can be deployed non-zonal.
pbrit pushed a commit to pbrit/terraform-provider-azurerm that referenced this pull request May 31, 2020
@ghost
Copy link

ghost commented Jun 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants