Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_logic_app_action_http: add run_after #7079

Merged
merged 1 commit into from May 26, 2020

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented May 26, 2020

Fixes #7069

Test Result

💤 😡 127 via 🦉 v1.14.3 make testacc TEST=./azurerm/internal/services/logic/tests TESTARGS="-run='TestAccAzureRMLogicAppActionHttp_runAfter'"                       
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/logic/tests -v -run='TestAccAzureRMLogicAppActionHttp_runAfter' -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMLogicAppActionHttp_runAfter
=== PAUSE TestAccAzureRMLogicAppActionHttp_runAfter
=== CONT  TestAccAzureRMLogicAppActionHttp_runAfter
--- PASS: TestAccAzureRMLogicAppActionHttp_runAfter (184.27s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/logic/tests 184.291s

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@@ -99,6 +123,10 @@ func resourceArmLogicAppActionHTTPCreateUpdate(d *schema.ResourceData, meta inte
"type": "http",
}

if v, ok := d.GetOk("run_after"); ok {
action["runAfter"] = expandLogicAppActionRunAfter(v.(*schema.Set).List())
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to set this to an empty array if this is unset?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test result shows that is not necessary. Also in the previous case where we didn't set it at all, it still works for the first level action (which is right after the trigger).

@tombuildsstuff tombuildsstuff added this to the v2.12.0 milestone May 26, 2020
@tombuildsstuff
Copy link
Member

Tests pass:

Screenshot 2020-05-26 at 12 20 55

@katbyte katbyte merged commit 869886e into hashicorp:master May 26, 2020
katbyte added a commit that referenced this pull request May 26, 2020
@ghost
Copy link

ghost commented May 28, 2020

This has been released in version 2.12.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.12.0"
}
# ... other configuration ...

pbrit pushed a commit to pbrit/terraform-provider-azurerm that referenced this pull request May 31, 2020
pbrit pushed a commit to pbrit/terraform-provider-azurerm that referenced this pull request May 31, 2020
@ghost
Copy link

ghost commented Jun 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jun 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_logic_app_action_http is missing support for Run After
3 participants