Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for versionless key vault secretId in azurerm_application_gateway #7095

Merged
merged 1 commit into from Jun 8, 2020

Conversation

t3mi
Copy link
Contributor

@t3mi t3mi commented May 26, 2020

Fixes #6188.

@ghost ghost added the size/L label May 26, 2020
@t3mi
Copy link
Contributor Author

t3mi commented May 26, 2020

=== RUN   TestAccAzureRMApplicationGateway_sslCertificate_keyvault_versionless
=== PAUSE TestAccAzureRMApplicationGateway_sslCertificate_keyvault_versionless
=== RUN   TestAccAzureRMApplicationGateway_sslCertificate_keyvault_versioned
=== PAUSE TestAccAzureRMApplicationGateway_sslCertificate_keyvault_versioned
=== CONT  TestAccAzureRMApplicationGateway_sslCertificate_keyvault_versionless
=== CONT  TestAccAzureRMApplicationGateway_sslCertificate_keyvault_versioned
--- PASS: TestAccAzureRMApplicationGateway_sslCertificate_keyvault_versionless (954.50s)
--- PASS: TestAccAzureRMApplicationGateway_sslCertificate_keyvault_versioned (954.48s)

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @t3mi

@tombuildsstuff tombuildsstuff merged commit c79c02e into hashicorp:master Jun 8, 2020
tombuildsstuff added a commit that referenced this pull request Jun 8, 2020
@ghost
Copy link

ghost commented Jun 11, 2020

This has been released in version 2.14.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.14.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jul 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for versionless key vault secretId in azurerm_application_gateway
2 participants