Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource/data source azurerm_logic_app_integration_account #7099

Merged
merged 7 commits into from Jun 2, 2020

Conversation

yupwei68
Copy link
Contributor

Partially fix: #2106

logic_app_work_flow integration test:
=== RUN TestAccAzureRMLogicAppWorkflow_integrationAccount
=== PAUSE TestAccAzureRMLogicAppWorkflow_integrationAccount
=== CONT TestAccAzureRMLogicAppWorkflow_integrationAccount
--- PASS: TestAccAzureRMLogicAppWorkflow_integrationAccount (196.99s)

resource test:
=== RUN TestAccAzureRMLogicAppIntegrationAccount_basic
=== PAUSE TestAccAzureRMLogicAppIntegrationAccount_basic
=== CONT TestAccAzureRMLogicAppIntegrationAccount_basic
--- PASS: TestAccAzureRMLogicAppIntegrationAccount_basic (94.94s)
=== RUN TestAccAzureRMLogicAppIntegrationAccount_requiresImport
=== PAUSE TestAccAzureRMLogicAppIntegrationAccount_requiresImport
=== CONT TestAccAzureRMLogicAppIntegrationAccount_requiresImport
--- PASS: TestAccAzureRMLogicAppIntegrationAccount_requiresImport (97.53s)
=== RUN TestAccAzureRMLogicAppIntegrationAccount_complete
=== PAUSE TestAccAzureRMLogicAppIntegrationAccount_complete
=== CONT TestAccAzureRMLogicAppIntegrationAccount_complete
--- PASS: TestAccAzureRMLogicAppIntegrationAccount_complete (96.88s)
=== RUN TestAccAzureRMLogicAppIntegrationAccount_update
=== PAUSE TestAccAzureRMLogicAppIntegrationAccount_update
=== CONT TestAccAzureRMLogicAppIntegrationAccount_update
--- PASS: TestAccAzureRMLogicAppIntegrationAccount_update (179.51s)
PASS

data source test:
=== RUN TestAccDataSourceAzureRMLogicAppIntegrationAccount_basic
=== PAUSE TestAccDataSourceAzureRMLogicAppIntegrationAccount_basic
=== CONT TestAccDataSourceAzureRMLogicAppIntegrationAccount_basic
--- PASS: TestAccDataSourceAzureRMLogicAppIntegrationAccount_basic (104.70s)
PASS

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yupwei68. This is looking good! I just have a couple minor issues but once that's cleared up we should be good to go!

@yupwei68 yupwei68 requested a review from mbfrahry June 1, 2020 02:44
@yupwei68
Copy link
Contributor Author

yupwei68 commented Jun 1, 2020

Hi @mbfrahry , thanks for your comments. Except one concern, changes have been pushed. Please continue reviewing.

@yupwei68
Copy link
Contributor Author

yupwei68 commented Jun 2, 2020

Hi @mbfrahry Please continue reviewing

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry merged commit 1db0001 into hashicorp:master Jun 2, 2020
mbfrahry added a commit that referenced this pull request Jun 2, 2020
@slessardjr
Copy link

I saw that this closed an issue. Will there be another PR for ISE as well?

@yupwei68 yupwei68 deleted the wyp-integrationacc branch June 3, 2020 01:49
@katbyte katbyte modified the milestones: 2.13.0, v2.17.0 Jun 26, 2020
@ghost
Copy link

ghost commented Jul 3, 2020

This has been released in version 2.17.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.17.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jul 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow linking a Logic App to an Integration Account
5 participants