Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource/datasource azurerm_data_share_dataset_blob_storage #7107

Merged
merged 8 commits into from Jun 18, 2020

Conversation

yupwei68
Copy link
Contributor

@yupwei68 yupwei68 commented May 27, 2020

Partially fix #6480

Sub PR of : #7064

resources:
azurerm_data_share_dataset_blob_storage
datashare dataset blob storage

data source:
azurerm_data_share_dataset_blob_storage
datashare dataset blob storage datasource

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for splitting this out @yupwei68, aside from a couple comments this is looking pretty good and the tests are passing

@yupwei68 yupwei68 requested a review from katbyte June 4, 2020 07:37
@yupwei68
Copy link
Contributor Author

yupwei68 commented Jun 4, 2020

Hi @katbyte , corresponding changes have been pushed. Please continue reviewing.
resource:

=== RUN   TestAccAzureRMDataShareDataSetBlobStorageFile_basic
--- PASS: TestAccAzureRMDataShareDataSetBlobStorageFile_basic (342.79s)
=== RUN   TestAccAzureRMDataShareDataSetBlobStorageFolder_basic
--- PASS: TestAccAzureRMDataShareDataSetBlobStorageFolder_basic (407.71s)
=== RUN   TestAccAzureRMDataShareDataSetBlobStorageContainer_basic
--- PASS: TestAccAzureRMDataShareDataSetBlobStorageContainer_basic (395.06s)
=== RUN   TestAccAzureRMDataShareDataSetBlobStorage_requiresImport
--- PASS: TestAccAzureRMDataShareDataSetBlobStorage_requiresImport (406.29s)

data source:

=== RUN   TestAccDataSourceAzureRMDataShareDatasetBlobStorage_basic
=== PAUSE TestAccDataSourceAzureRMDataShareDatasetBlobStorage_basic
=== CONT  TestAccDataSourceAzureRMDataShareDatasetBlobStorage_basic
--- PASS: TestAccDataSourceAzureRMDataShareDatasetBlobStorage_basic (455.41s)

@tombuildsstuff tombuildsstuff modified the milestones: v2.13.0, v2.14.0 Jun 4, 2020
@tombuildsstuff tombuildsstuff modified the milestones: v2.14.0, v2.15.0 Jun 11, 2020
@jackofallops
Copy link
Member

Tests for service pass:
image

@jackofallops jackofallops merged commit de16440 into hashicorp:master Jun 18, 2020
jackofallops added a commit that referenced this pull request Jun 18, 2020
@ghost
Copy link

ghost commented Jun 19, 2020

This has been released in version 2.15.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.15.0"
}
# ... other configuration ...

@yupwei68 yupwei68 deleted the wyp-datashare-dataset-blob branch July 10, 2020 02:02
@ghost
Copy link

ghost commented Jul 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jul 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for [Data Share]
4 participants