Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_eventhub_authorization_rule - Fix intermittent 404 errors #7122

Merged
merged 9 commits into from Jun 1, 2020

Conversation

nickmhankins
Copy link
Contributor

@nickmhankins nickmhankins commented May 28, 2020

@ghost ghost added the size/S label May 28, 2020
@nickmhankins
Copy link
Contributor Author

Looks like this failed for other reasons:

curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $GOPATH/bin v1.24.0

golangci/golangci-lint info checking GitHub for tag 'v1.24.0'

golangci/golangci-lint info found version: 1.24.0 for v1.24.0/linux/amd64

GNUmakefile:14: recipe for target 'tools' failed

make: *** [tools] Error 1

The command "make tools" failed and exited with 2 during .

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nickmhankins, this looks good! I just think we can be a little more specific on the RetryableError piece

}
read, err := client.GetAuthorizationRule(ctx, resourceGroup, namespaceName, eventHubName, name)
if err != nil {
return resource.RetryableError(fmt.Errorf("Expected instance of the authorization rule %q (event Hub %q / Namespace %q / Resource Group %q) to be created but was in non existent state, retrying", name, eventHubName, namespaceName, resourceGroup))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What're your thoughts on retrying only when we error on a 404? Make it a little more specific to the error we are trying to solve

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great idea, i'll work on that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbfrahry Requested change has been made

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry changed the title Event Hub Authorization Rule intermittent 404 errors azurerm_eventhub_authorization_rule - Fix intermittent 404 errors Jun 1, 2020
@mbfrahry mbfrahry merged commit a51c8a7 into hashicorp:master Jun 1, 2020
mbfrahry added a commit that referenced this pull request Jun 1, 2020
@ghost
Copy link

ghost commented Jul 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jul 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants