Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_network_watcher_flow_log destroy fails #7154

Merged
merged 4 commits into from Jun 16, 2020

Conversation

yupwei68
Copy link
Contributor

@yupwei68 yupwei68 commented Jun 1, 2020

Fix #6913

=== RUN TestAccAzureRMNetworkWatcherFlowLog_basic
--- PASS: TestAccAzureRMNetworkWatcherFlowLog_basic (160.70s)
=== RUN TestAccAzureRMNetworkWatcherFlowLog_disabled
--- PASS: TestAccAzureRMNetworkWatcherFlowLog_disabled (143.00s)
=== RUN TestAccAzureRMNetworkWatcherFlowLog_reenabled
--- PASS: TestAccAzureRMNetworkWatcherFlowLog_reenabled (207.17s)
=== RUN TestAccAzureRMNetworkWatcherFlowLog_retentionPolicy
--- PASS: TestAccAzureRMNetworkWatcherFlowLog_retentionPolicy (201.46s)
=== RUN TestAccAzureRMNetworkWatcherFlowLog_updateStorageAccount
--- PASS: TestAccAzureRMNetworkWatcherFlowLog_updateStorageAccount (228.93s)
=== RUN TestAccAzureRMNetworkWatcherFlowLog_trafficAnalytics
--- PASS: TestAccAzureRMNetworkWatcherFlowLog_trafficAnalytics (359.23s)
=== RUN TestAccAzureRMNetworkWatcherFlowLog_version
--- PASS: TestAccAzureRMNetworkWatcherFlowLog_version (198.51s)
PASS

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @yupwei68

Thanks for this PR - taking a look through this is looking good, if we can revert the changes to the test function then this otherwise LGTM 👍

Thanks!

@ghost ghost added size/XS and removed size/S labels Jun 9, 2020
@yupwei68
Copy link
Contributor Author

yupwei68 commented Jun 9, 2020

@tombuildsstuff @katbyte Thanks for your comments. Please continue reviewing.

@ghost ghost removed the waiting-response label Jun 9, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yupwei68 - LGTM 👍

@katbyte katbyte merged commit fed0227 into hashicorp:master Jun 16, 2020
katbyte added a commit that referenced this pull request Jun 16, 2020
@yupwei68 yupwei68 deleted the wyp-network-watcherFlow branch July 10, 2020 02:02
@ghost
Copy link

ghost commented Jul 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jul 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Destroy azurerm_network_watcher_flow_log fails if traffic_analytics is not enabled
4 participants