Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_virtual_network_gatway - vpn_client_protocols is now also computed to prevent permanent diffs #7168

Merged
merged 1 commit into from Jun 2, 2020

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Jun 2, 2020

fixes #1817

After tested, I found seems the api behavior has been changed. root_certificate wouldn't be automatically generated while not specifying. So no need to fix it. So I just fix vpn_client_protocols in this PR.

@ghost ghost added the size/XS label Jun 2, 2020
@mbfrahry mbfrahry changed the title Suppress diff for property vpn_client_protocols of vnet gateway azurerm_virtual_network_gatway - vpn_client_protocols is now also computed to prevent permanent diffs Jun 2, 2020
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry merged commit 1234562 into hashicorp:master Jun 2, 2020
mbfrahry added a commit that referenced this pull request Jun 2, 2020
@ghost
Copy link

ghost commented Jul 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jul 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_virtual_network_gateway - modifies the default properties
3 participants