Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure policy rest version bump to 2019-09-01 #7211

Merged
merged 1 commit into from Jun 8, 2020

Conversation

jlpedrosa
Copy link
Contributor

@jlpedrosa jlpedrosa commented Jun 4, 2020

Azure sdk for policies bump to version '2019-09-01'.

References: #7210

Fixes #7210

@ArcturusZhang
Copy link
Contributor

Hi @jlpedrosa thanks for this PR.
But I am afraid that this is a duplicate of PR #7018

@jlpedrosa
Copy link
Contributor Author

Hi @ArcturusZhang
This PR is looking to be 100% backwards compatible and not introduce any breaking change. The tests don't need to be changed and existing acctests are passing just fine. As this is already an XXL change (but smaller than he other PR) maybe it's easier to merge this one and latter add the new feature.
What ever they decide is fine for me as long as one of them gets merged.

@ArcturusZhang
Copy link
Contributor

Hi @jlpedrosa make sense. Looking forward for this getting merged, and I then will rebase mine on this. Thanks!

@katbyte katbyte added this to the v2.14.0 milestone Jun 8, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jlpedrosa - appreciate the api upgrade without any other changes! LGTM

@katbyte katbyte merged commit 6db45cd into hashicorp:master Jun 8, 2020
katbyte added a commit that referenced this pull request Jun 8, 2020
@jlpedrosa
Copy link
Contributor Author

jlpedrosa commented Jun 9, 2020

Hi @ArcturusZhang
This PR has been merged. I think you could rebase yours from master and update it.

@ghost
Copy link

ghost commented Jun 11, 2020

This has been released in version 2.14.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.14.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 9, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jul 9, 2020
@jlpedrosa jlpedrosa deleted the policy_modes branch July 9, 2020 15:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Policies with all modes not only All, Indexed
4 participants