`azurerm_private_endpoint` - expose `private_dns_zone_group`, `private_dns_zone_configs`, and `custom_dns_configs` #7246

WodansSon · 2020-06-08T07:07:42Z

(fixes #6571)

WodansSon · 2020-06-11T08:39:46Z

tombuildsstuff

partial review as discussed offline

azurerm/internal/services/network/parse/private_endpoint.go

tombuildsstuff · 2020-06-11T09:29:01Z

azurerm/internal/services/network/parse/private_endpoint.go

+		Name:          id.Path["privateDnsZoneGroups"],
+		ResourceGroup: id.ResourceGroup,
+		ID:            input,
+	}


we should use the PopSegment and ValidateNoEmptySegments functions here to ensure this is the ID of a private endpoint and not something else

Mostly Fixed. I can't use ValidateNoEmptySegments because I am parsing the information for multiple resources from one resource ID(e.g. /subscriptions/XXXX/resourceGroups/jcline-privateDns-rg/providers/Microsoft.Network/privateEndpoints/contoso-cosmosdb/privateDnsZoneGroups/privatelink.postgres.database.azure.com2/privateDnsZoneConfigs/finance-contoso-com.

tombuildsstuff · 2020-06-11T09:29:06Z

azurerm/internal/services/network/parse/private_endpoint.go

+	return privateDnsZoneGroup, nil
+}
+
+func PrivateDnsZoneResourceIDs(input []interface{}) ([]NameResourceGroup, error) {


(same here)

tombuildsstuff · 2020-06-11T09:29:34Z

azurerm/internal/services/network/parse/private_endpoint.go

+	return results, nil
+}
+
+func PrivateEndpointResourceID(input string) (NameResourceGroup, error) {


(same here)

tombuildsstuff · 2020-06-11T09:29:38Z

azurerm/internal/services/network/parse/private_endpoint.go

+			Name:          id.Path["privateDnsZones"],
+			ResourceGroup: id.ResourceGroup,
+			ID:            v,
+		}


(same here)

tombuildsstuff · 2020-06-11T09:29:54Z

azurerm/internal/services/network/parse/private_endpoint.go

+		}
+
+		privateDnsZone := NameResourceGroup{
+			Name:          id.Path["privateDnsZones"],


can we pull this out into a separate ParseDNSZoneResourceID method?

tombuildsstuff · 2020-06-11T09:30:18Z

azurerm/internal/services/network/private_endpoint_resource.go

+							Required: true,
+							Elem: &schema.Schema{
+								Type:         schema.TypeString,
+								ValidateFunc: azure.ValidateResourceID,


which then means we can validate this is a Private DNS Zone ID here

azurerm/internal/services/network/private_endpoint_resource.go

tombuildsstuff · 2020-06-12T18:21:49Z

azurerm/internal/services/network/private_endpoint_resource.go

 	}
 	if resp.ID == nil || *resp.ID == "" {
 		return fmt.Errorf("API returns a nil/empty id on Private Endpoint %q (Resource Group %q): %+v", name, resourceGroup, err)
 	}
 	d.SetId(*resp.ID)

+	// now create the dns zone group
+	// first I have to see if the dns zone group exists, if it does I need to delete it an re-create it because you can only have one per private endpoint


what happens to traffic when this is deleted, is this dropped? if so - should we be locating the existing one and updating instead?

I only delete if the name has changed, else I will need to force new the attribute which would delete the entire private endpoint. Once the private DNS zone group is deleted the traffic is automatically re-routed to the existing private endpoint FQDN which is displayed via the custom DNS configs attribute.

Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>

WodansSon · 2020-06-18T05:01:06Z

=== RUN TestAccAzureRMPrivateEndpoint_basic
=== PAUSE TestAccAzureRMPrivateEndpoint_basic
=== RUN TestAccAzureRMPrivateEndpoint_updateTag
=== PAUSE TestAccAzureRMPrivateEndpoint_updateTag
=== RUN TestAccAzureRMPrivateEndpoint_requestMessage
=== PAUSE TestAccAzureRMPrivateEndpoint_requestMessage
=== RUN TestAccAzureRMPrivateEndpoint_privateDnsZoneGroup
=== PAUSE TestAccAzureRMPrivateEndpoint_privateDnsZoneGroup
=== RUN TestAccAzureRMPrivateEndpoint_privateDnsZoneRename
=== PAUSE TestAccAzureRMPrivateEndpoint_privateDnsZoneRename
=== RUN TestAccAzureRMPrivateEndpoint_privateDnsZoneUpdate
=== PAUSE TestAccAzureRMPrivateEndpoint_privateDnsZoneUpdate
=== RUN TestAccAzureRMPrivateEndpoint_privateDnsZoneRemove
=== PAUSE TestAccAzureRMPrivateEndpoint_privateDnsZoneRemove
=== CONT TestAccAzureRMPrivateEndpoint_basic
=== CONT TestAccAzureRMPrivateEndpoint_privateDnsZoneRename
=== CONT TestAccAzureRMPrivateEndpoint_privateDnsZoneRemove
=== CONT TestAccAzureRMPrivateEndpoint_privateDnsZoneUpdate
=== CONT TestAccAzureRMPrivateEndpoint_requestMessage
=== CONT TestAccAzureRMPrivateEndpoint_privateDnsZoneGroup
=== CONT TestAccAzureRMPrivateEndpoint_updateTag
--- PASS: TestAccAzureRMPrivateEndpoint_basic (179.87s)
--- PASS: TestAccAzureRMPrivateEndpoint_updateTag (237.52s)
--- PASS: TestAccAzureRMPrivateEndpoint_requestMessage (255.87s)
--- PASS: TestAccAzureRMPrivateEndpoint_privateDnsZoneGroup (313.20s)
--- PASS: TestAccAzureRMPrivateEndpoint_privateDnsZoneRename (362.99s)
--- PASS: TestAccAzureRMPrivateEndpoint_privateDnsZoneRemove (390.92s)
--- PASS: TestAccAzureRMPrivateEndpoint_privateDnsZoneUpdate (485.42s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/network/tests 485.510s

katbyte

aside from one comment LGTM 👍

katbyte · 2020-06-18T20:12:44Z

azurerm/internal/services/network/private_endpoint_resource.go

+	result["id"] = *input.ID
+	result["name"] = *input.Name


We should nil check these?

WodansSon · 2020-06-18T20:56:56Z

ghost · 2020-06-19T02:33:06Z

This has been released in version 2.15.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.15.0"
}
# ... other configuration ...

ghost · 2020-07-19T14:50:30Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

WodansSon added 5 commits May 19, 2020 13:50

Fixed requiresImport test case

4f44dda

Progress exposing dns zone groups

6a4ae70

Work thus far redesign

8631c09

Progress thus far

a4db18c

Progress

806d32f

ghost added the size/XL label Jun 8, 2020

WodansSon added documentation enhancement service/private-link labels Jun 8, 2020

WodansSon changed the title ~~[WIP] azurerm_private_endpoint - expose custom_dns_configs~~ [WIP] azurerm_private_endpoint - expose custom_dns_configs add New Resource: azurerm_private_dns_zone_group Jun 8, 2020

WodansSon added 4 commits June 8, 2020 16:39

Change data structure

afdf68d

Close mostly working now

af3b826

Remove old resources

6379995

Code complete needs docs and tests

00b7771

WodansSon changed the title ~~[WIP] azurerm_private_endpoint - expose custom_dns_configs add New Resource: azurerm_private_dns_zone_group~~ [WIP] azurerm_private_endpoint - expose private_dns_zone_group, private_dns_zone_configs, and custom_dns_configs and Jun 11, 2020

WodansSon added this to the v2.14.0 milestone Jun 11, 2020

WodansSon added 2 commits June 10, 2020 20:56

Add docs and example

15eaab3

Added Tests and updated docs

28b8890

ghost added size/XXL and removed size/XL labels Jun 11, 2020

Fix Lint Errors

20ecd20

WodansSon changed the title ~~[WIP] azurerm_private_endpoint - expose private_dns_zone_group, private_dns_zone_configs, and custom_dns_configs and~~ azurerm_private_endpoint - expose private_dns_zone_group, private_dns_zone_configs, and custom_dns_configs and Jun 11, 2020

WodansSon changed the title ~~azurerm_private_endpoint - expose private_dns_zone_group, private_dns_zone_configs, and custom_dns_configs and~~ azurerm_private_endpoint - expose private_dns_zone_group, private_dns_zone_configs, and custom_dns_configs Jun 11, 2020

tombuildsstuff modified the milestones: v2.14.0, v2.15.0 Jun 11, 2020

tombuildsstuff self-requested a review June 11, 2020 08:52

tombuildsstuff removed this from the v2.14.0 milestone Jun 11, 2020

tombuildsstuff added this to the v2.15.0 milestone Jun 11, 2020

tombuildsstuff reviewed Jun 12, 2020

View reviewed changes

WodansSon and others added 5 commits June 15, 2020 21:00

Update azurerm/internal/services/network/parse/private_endpoint.go

208d980

Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>

Update azurerm/internal/services/network/private_endpoint_resource.go

1f1b8b9

Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>

Update azurerm/internal/services/network/private_endpoint_resource.go

072f4c5

Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>

Changes per PR

bf453a6

Fix lint error

bc9751d

katbyte approved these changes Jun 18, 2020

View reviewed changes

Requested changes per PR comment

fe072dc

WodansSon merged commit ce3eb26 into master Jun 18, 2020

WodansSon deleted the e_privateEndpoint_privateDnsZoneConfigs branch June 18, 2020 20:58

WodansSon added a commit that referenced this pull request Jun 18, 2020

updating to include #7246

a43ed91

poddm mentioned this pull request Jul 14, 2020

azurerm_private_endpoint.private_dns_zone_group - created A records aren't idempotent. #7726

Closed

hashicorp locked and limited conversation to collaborators Jul 19, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`azurerm_private_endpoint` - expose `private_dns_zone_group`, `private_dns_zone_configs`, and `custom_dns_configs` #7246

`azurerm_private_endpoint` - expose `private_dns_zone_group`, `private_dns_zone_configs`, and `custom_dns_configs` #7246

WodansSon commented Jun 8, 2020

WodansSon commented Jun 11, 2020

tombuildsstuff left a comment

tombuildsstuff Jun 11, 2020

WodansSon Jun 18, 2020 •

edited

tombuildsstuff Jun 11, 2020

tombuildsstuff Jun 11, 2020

WodansSon Jun 18, 2020

tombuildsstuff Jun 11, 2020

WodansSon Jun 18, 2020

tombuildsstuff Jun 11, 2020

WodansSon Jun 18, 2020

tombuildsstuff Jun 11, 2020

WodansSon Jun 18, 2020

tombuildsstuff Jun 12, 2020

WodansSon Jun 16, 2020 •

edited

WodansSon commented Jun 18, 2020

katbyte left a comment

katbyte Jun 18, 2020

WodansSon commented Jun 18, 2020

ghost commented Jun 19, 2020

ghost commented Jul 19, 2020

azurerm_private_endpoint - expose private_dns_zone_group, private_dns_zone_configs, and custom_dns_configs #7246

azurerm_private_endpoint - expose private_dns_zone_group, private_dns_zone_configs, and custom_dns_configs #7246

Conversation

WodansSon commented Jun 8, 2020

WodansSon commented Jun 11, 2020

tombuildsstuff left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WodansSon Jun 18, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WodansSon Jun 16, 2020 • edited

Choose a reason for hiding this comment

WodansSon commented Jun 18, 2020

katbyte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WodansSon commented Jun 18, 2020

ghost commented Jun 19, 2020

ghost commented Jul 19, 2020

`azurerm_private_endpoint` - expose `private_dns_zone_group`, `private_dns_zone_configs`, and `custom_dns_configs` #7246

`azurerm_private_endpoint` - expose `private_dns_zone_group`, `private_dns_zone_configs`, and `custom_dns_configs` #7246

WodansSon Jun 18, 2020 •

edited

WodansSon Jun 16, 2020 •

edited