Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/eventhub_namespace_authorization_rule: adding a state migration #7248

Merged
merged 1 commit into from Jun 9, 2020

Conversation

tombuildsstuff
Copy link
Member

This PR supersedes #7147 (by @markusleh) and #7244 (by @neil-yechenwei) by introducing a State Migration to ensure the ID is consistent - rather than working only for users who've newly created resources - meaning that all resources will get upgraded to become AuthorizationRules.

This PR also splits out a Parser from this, since it seemed like as good a time as any to do so.

Fixes #7162

Updating the ID from `authorizationRules` to `AuthorizationRules`, also splitting
out a Parser from this - since it seems like as good-a-time-as-any
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit bb7e21c into master Jun 9, 2020
@tombuildsstuff tombuildsstuff deleted the f/event-hub-auth-rules branch June 9, 2020 09:57
tombuildsstuff added a commit that referenced this pull request Jun 9, 2020
@ghost
Copy link

ghost commented Jun 11, 2020

This has been released in version 2.14.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.14.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 9, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jul 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error making Read request on Azure EventHub Authorization Rule
2 participants