Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add developer_portal_url attribute on azurerm_api_management #7263

Merged
merged 2 commits into from Jun 12, 2020

Conversation

sirlatrom
Copy link
Contributor

Fixes #7261.

@ghost ghost added the size/XS label Jun 9, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @sirlatrom, could we update the docs with the new property? other then that looks good!

Signed-off-by: Sune Keller <absukl@almbrand.dk>
Signed-off-by: Sune Keller <absukl@almbrand.dk>
@sirlatrom
Copy link
Contributor Author

One day I'm going to submit a PR that has both docs, tests and implementation in one go :)

@ghost ghost removed the waiting-response label Jun 10, 2020
@tombuildsstuff tombuildsstuff modified the milestones: v2.14.0, v2.15.0 Jun 11, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄 - thanks @sirlatrom LGTM now!

@katbyte katbyte merged commit 84e0905 into hashicorp:master Jun 12, 2020
katbyte added a commit that referenced this pull request Jun 12, 2020
@ghost
Copy link

ghost commented Jun 19, 2020

This has been released in version 2.15.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.15.0"
}
# ... other configuration ...

@sirlatrom sirlatrom deleted the fix-7261 branch July 8, 2020 07:36
@ghost
Copy link

ghost commented Jul 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jul 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for developer_portal_url attribute on azurerm_api_management
3 participants