Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_hdinsight_cluster deprecate min_instance_count #7272

Merged
merged 1 commit into from Jun 16, 2020

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Jun 10, 2020

This address part of #7067.

min_instance_count has no effect during resource creation for
hdinsight cluster resource set. Besides, it actually cause plan skew if
user specified it to a non-zero value.

Test Result

💤 via 🦉 v1.14.4 make testacc TEST=./azurerm/internal/services/hdinsight/tests TESTARGS="-run='TestAccAzureRMHDInsightKafkaCluster_basic|TestAccAzureRMHDInsightHadoopCluster_basic'"
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/hdinsight/tests -v -run='TestAccAzureRMHDInsightKafkaCluster_basic|TestAccAzureRMHDInsightHadoopCluster_basic' -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMHDInsightHadoopCluster_basic
=== PAUSE TestAccAzureRMHDInsightHadoopCluster_basic
=== RUN   TestAccAzureRMHDInsightKafkaCluster_basic
=== PAUSE TestAccAzureRMHDInsightKafkaCluster_basic
=== CONT  TestAccAzureRMHDInsightHadoopCluster_basic
=== CONT  TestAccAzureRMHDInsightKafkaCluster_basic
--- PASS: TestAccAzureRMHDInsightKafkaCluster_basic (1154.21s)
--- PASS: TestAccAzureRMHDInsightHadoopCluster_basic (1169.71s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/hdinsight/tests     1169.741s

This address part of hashicorp#7067.

min_instance_count has no effect during resource creation for
hdinsight cluster resource set. Besides, it actually cause plan skew if
user specified it to a non-zero value.
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @magodo, this LGTM ! 👍

@katbyte katbyte added this to the v2.15.0 milestone Jun 11, 2020
@magodo
Copy link
Collaborator Author

magodo commented Jun 16, 2020

@katbyte Any chance to merge this PR?
Also, remember to merge #7111 which complement this PR to fix #7067

@katbyte katbyte merged commit 112e6ee into hashicorp:master Jun 16, 2020
katbyte added a commit that referenced this pull request Jun 16, 2020
@ghost
Copy link

ghost commented Jun 19, 2020

This has been released in version 2.15.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.15.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jul 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants