Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calling_web_hook could be empty for azurerm_bot_channel_ms_teams #7294

Merged
merged 1 commit into from Jun 11, 2020

Conversation

njuCZ
Copy link
Contributor

@njuCZ njuCZ commented Jun 11, 2020

fix #5450

  • when callingWebHook is empty, make the field be nil. In this way, the backend service will not validate this field

After fix this bug, I encountered another bug:
calling_web_hook could not be updated to empty because the update is a patch rest api, It will omit the empty parameter, the field calling_web_hook will remain the last value.
I have submitted an issue in the rest-api-spec:
Azure/azure-rest-api-specs#9809

to avoid diff in terraform, I added comuted: true

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Member

Test passes:

Screenshot 2020-06-11 at 12 25 04

@tombuildsstuff tombuildsstuff added this to the v2.14.0 milestone Jun 11, 2020
@tombuildsstuff tombuildsstuff merged commit 92539a8 into hashicorp:master Jun 11, 2020
tombuildsstuff added a commit that referenced this pull request Jun 11, 2020
@ghost
Copy link

ghost commented Jun 11, 2020

This has been released in version 2.14.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.14.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jul 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_bot_channel_ms_teams requires that calling_web_hook be set
2 participants