Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare azurerm_healthcare_service argument access_policy_object_ids as optional #7296

Conversation

sschmeck
Copy link
Contributor

Fixes #7281 (#7292).

@ghost ghost added the size/XS label Jun 11, 2020
@katbyte katbyte added this to the v2.15.0 milestone Jun 12, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sschmeck! Is this property deprecated or just optional now? one of the issues linked suggests it maybe should be marked as deprecated?

either way the docs need to be updated to mark it as optional and then it'll be gtg 🙂

@sschmeck
Copy link
Contributor Author

sschmeck commented Jun 12, 2020

@katbyte Currently the Azure Provider documentation describes the attribute already as optional, see azurerm_healthcare_service. But the implementation differed from the docs.

It's not clear, where you found the suggestion, that it should marked as deprecated. Could you point to the section, please?

Thanks :)

@ghost ghost removed the waiting-response label Jun 12, 2020
@sschmeck sschmeck requested a review from katbyte June 12, 2020 16:03
@katbyte
Copy link
Collaborator

katbyte commented Jun 12, 2020

i cannot 😅 - i must have gotten it confused with another issue. alls we need is the docs updated and this should be gtg 🙂

@sschmeck
Copy link
Contributor Author

@katbyte Sorry for the question, but have you checked the docs? Why should we update them? The docs say already its optional and the implementation allows it now.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not 🤦‍♀️ - just assumed they were correct to being with, sorry

LGTM @sschmeck!

@katbyte katbyte merged commit 24223d2 into hashicorp:master Jun 14, 2020
katbyte added a commit that referenced this pull request Jun 14, 2020
@ghost
Copy link

ghost commented Jun 19, 2020

This has been released in version 2.15.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.15.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jul 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants