Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_storage_share_directory - name can now contain one nested directory #7382

Merged
merged 4 commits into from Jun 17, 2020

Conversation

jogleasonjr
Copy link
Contributor

@jogleasonjr jogleasonjr commented Jun 17, 2020

This PR allows hyphens in the names of nested file share directories, for example:

abc/hello-world

This is noted in this comment by JeremiahInMN as part of an issue around multi-level directory nesting.

@ghost ghost added size/S and removed size/XS labels Jun 17, 2020
@ghost ghost added size/XS and removed size/S labels Jun 17, 2020
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! No worries on the mixup @jogleasonjr

@mbfrahry mbfrahry changed the title Allow hyphens in the the names of nested file share directories azurerm_storage_share_directory - name can now contain one nested directory Jun 17, 2020
@mbfrahry mbfrahry merged commit a24b027 into hashicorp:master Jun 17, 2020
mbfrahry added a commit that referenced this pull request Jun 17, 2020
@ghost
Copy link

ghost commented Jul 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jul 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants