Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_storage_account_network_rules - correctly clear ip_rules, virtual_network_subnet_ids when set to [] #7385

Merged
merged 1 commit into from Jun 23, 2020

Conversation

njuCZ
Copy link
Contributor

@njuCZ njuCZ commented Jun 18, 2020

fix #7357

"getOk" will ignore the zero value, and the rules will always contain last value
we could directly get the vaules and pass them

image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @njuCZ LGTM 👍

@katbyte katbyte merged commit a21bd9d into hashicorp:master Jun 23, 2020
katbyte added a commit that referenced this pull request Jun 23, 2020
@katbyte katbyte changed the title make ip_rules, virtual_network_subnet_ids could become zero - azurerm_storage_account_network_rules azurerm_storage_account_network_rules - correctly clear ip_rules, virtual_network_subnet_ids when set to [] Jun 23, 2020
@ghost
Copy link

ghost commented Jun 25, 2020

This has been released in version 2.16.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.16.0"
}
# ... other configuration ...

jrauschenbusch pushed a commit to jrauschenbusch/terraform-provider-azurerm that referenced this pull request Jun 29, 2020
…urerm_storage_account_network_rules` (hashicorp#7385)

fix hashicorp#7357

"getOk" will ignore the zero value, and the rules will always contain last value
we could directly get the vaules and pass them
jrauschenbusch pushed a commit to jrauschenbusch/terraform-provider-azurerm that referenced this pull request Jun 29, 2020
jrauschenbusch pushed a commit to jrauschenbusch/terraform-provider-azurerm that referenced this pull request Jun 29, 2020
…urerm_storage_account_network_rules` (hashicorp#7385)

fix hashicorp#7357

"getOk" will ignore the zero value, and the rules will always contain last value
we could directly get the vaules and pass them
jrauschenbusch pushed a commit to jrauschenbusch/terraform-provider-azurerm that referenced this pull request Jun 29, 2020
@ghost
Copy link

ghost commented Jul 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jul 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_storage_account_network_rules not clearing out ip_rules nor virtual_network_subnet_ids
2 participants