Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new resource: azurerm_postgresql_active_directory_administrator #7411

Merged

Conversation

evertonmc
Copy link
Contributor

Fixes #6110
Allows you to set a user or group as the AD administrator for an PostgreSQL server in Azure
Based on https://github.com/Azure/azure-sdk-for-go/blob/master/services/postgresql/mgmt/2017-12-01/postgresql/serveradministrators.go

@evertonmc evertonmc marked this pull request as ready for review June 19, 2020 12:13
@evertonmc evertonmc changed the title add aad admin for azurerm_postgresql_server add AD admin for azurerm_postgresql_server Jun 19, 2020
@evertonmc evertonmc changed the title add AD admin for azurerm_postgresql_server new resource: azurerm_postgresql_active_directory_administrator Jun 19, 2020
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @evertonmc

@tombuildsstuff
Copy link
Member

hey @evertonmc

Running the tests for this it appears the PostgreSQL Server resources need a few more fields to be usable:

------ Stdout: -------
=== RUN   TestAccAzurePostgreSqlAdministrator_basic
=== PAUSE TestAccAzurePostgreSqlAdministrator_basic
=== CONT  TestAccAzurePostgreSqlAdministrator_basic
TestAccAzurePostgreSqlAdministrator_basic: testing.go:640: Step 0 error: config is invalid: Missing required argument: The argument "sku_name" is required, but no definition was found.
--- FAIL: TestAccAzurePostgreSqlAdministrator_basic (0.51s)
FAIL

Would you mind updating the PostgreSQL Server resources in the tests to account for that?

Thanks!

@evertonmc
Copy link
Contributor Author

@tombuildsstuff thanks. Yeah, that's true. Done in this update

@ghost ghost removed the waiting-response label Jun 24, 2020
@tombuildsstuff tombuildsstuff added this to the v2.16.0 milestone Jun 25, 2020
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for pushing those changes @evertonmc

@tombuildsstuff
Copy link
Member

Tests pass:

Screenshot 2020-06-25 at 11 33 17

@tombuildsstuff tombuildsstuff merged commit 7fedb2e into hashicorp:master Jun 25, 2020
tombuildsstuff added a commit that referenced this pull request Jun 25, 2020
@evertonmc evertonmc deleted the feature/postgresql_aad_admin branch June 25, 2020 09:54
@ghost
Copy link

ghost commented Jun 25, 2020

This has been released in version 2.16.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.16.0"
}
# ... other configuration ...

jrauschenbusch pushed a commit to jrauschenbusch/terraform-provider-azurerm that referenced this pull request Jun 29, 2020
@ghost
Copy link

ghost commented Jul 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jul 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for adding Azure AD admin user on Azure Database for PostgreSQL server
3 participants