Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_hdinsights_*_cluster: loosen work node count validation #7430

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Jun 22, 2020

The limitation should be loosened for work nodes (there already exists this case in the current code base), and I can't find the source for current hard limits.

From the document: https://docs.microsoft.com/en-us/azure/hdinsight/hdinsight-supported-node-configuration

If you need more than 32 worker nodes in a cluster, select a head node size with at least 8 cores and 14 GB of RAM.

And this is the exact behavior in Portal.

So I would suggest loosening the constraints for work node count.

(this fix #7342 )

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @magodo
Thanks for this PR, it looks mostly fine with one comment that I suspect is a copy-paste error? If you can address that I'll get the tests run and hopefully get this in the next release!

Thanks again
Ste

@jackofallops jackofallops added this to the v2.16.0 milestone Jun 22, 2020
@magodo
Copy link
Collaborator Author

magodo commented Jun 22, 2020

@jackofallops I have updated the typo, please take a look :)

@magodo magodo requested a review from jackofallops June 22, 2020 23:27
@jackofallops
Copy link
Member

Tests looking good:
image
(Failures are unrelated / transient)

@jackofallops jackofallops merged commit 1e7a8cc into hashicorp:master Jun 23, 2020
jackofallops added a commit that referenced this pull request Jun 23, 2020
katbyte added a commit that referenced this pull request Jun 23, 2020
@ghost
Copy link

ghost commented Jun 25, 2020

This has been released in version 2.16.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.16.0"
}
# ... other configuration ...

jrauschenbusch pushed a commit to jrauschenbusch/terraform-provider-azurerm that referenced this pull request Jun 29, 2020
jrauschenbusch pushed a commit to jrauschenbusch/terraform-provider-azurerm that referenced this pull request Jun 29, 2020
jrauschenbusch pushed a commit to jrauschenbusch/terraform-provider-azurerm that referenced this pull request Jun 29, 2020
jrauschenbusch pushed a commit to jrauschenbusch/terraform-provider-azurerm that referenced this pull request Jun 29, 2020
@ghost
Copy link

ghost commented Jul 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jul 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_hdinsight_hbase_cluster has incorrect worker node target_instance_count limit
3 participants